[MCC-1510053] Python Lib- Create a function to retrieve all the list …#52
Merged
Conversation
butsyk-mdsol
requested review from
afieraru-mdsol,
dsilaghi-mdsol and
ibaig-mdsol
There was a problem hiding this comment.
Pull request overview
Adds a new public API (get_datetime_formats) to retrieve supported date/datetime format patterns from the backend, with optional server-side filtering and a typed domain result to help consumers use datetime_formats correctly during dry_publish / publish.
Changes:
- Introduces
get_datetime_formatsend-to-end (client → service → transport) and adds new request/result models. - Adds a comprehensive new unit test suite covering domain helpers, service validation/translation, transport action encoding/decoding, and client delegation.
- Updates README and the usage notebook with examples for discovering supported formats.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_publish.py | Updates Transport stub to satisfy the expanded Transport ABC. |
| tests/test_get_datetime_formats.py | New test suite validating behavior across domain/service/transport/client layers. |
| tests/test_dry_publish.py | Updates Transport stub to satisfy the expanded Transport ABC (currently includes an incorrect type annotation). |
| readme/README-v1.0.0.md | Documents get_datetime_formats() API, arguments, and result helpers with example usage. |
| guides/dataconnect_usage.ipynb | Adds a notebook section demonstrating how to retrieve and inspect supported formats. |
| dataconnect/transport/models.py | Adds DatetimeFormatsRequest transport DTO. |
| dataconnect/transport/base.py | Extends Transport ABC with get_datetime_formats. |
| dataconnect/transport/arrow_flight/transport.py | Implements the Flight action call/JSON decoding for get_datetime_formats. |
| dataconnect/service/default.py | Implements validation/normalization and classification into DatetimeFormatsResult. |
| dataconnect/service/base.py | Adds get_datetime_formats to the service interface. |
| dataconnect/models.py | Adds DatetimeFormat and DatetimeFormatsResult domain models + convenience accessors. |
| dataconnect/client.py | Exposes DataConnectClient.get_datetime_formats façade method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…of date/datetime formats we support
butsyk-mdsol
force-pushed
the
feat/MCC-1513773
branch
from
6a74e21 to
7b0d196
Compare
afieraru-mdsol
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…of date/datetime formats we support
feature/bug/enhance/refactor/tech_debt/hotfix
Python Lib- Create a function to retrieve all the list of date/datetime formats we support.MCC-1510053Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
Add a new get_datetime_formats() function to the Jupyter file that returns the full list of 128 supported date and datetime format strings.
Implement get_datetime_formats in Jupyter file with type filter support for all, date, datetime
Return a structured object with index, format, and type columns.
Ensure all returns 128 entries
Add or update automated tests for function behavior, filtering, invalid input, and publish mapping compatibility.
Update README and usage guide
AC: